-
Notifications
You must be signed in to change notification settings - Fork 180
fix: helm operation in progress #2708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CasLubbers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm. Deleted the operator multiple times and install continues
j-zimnowoda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix types
src/operator/installer.ts
Outdated
| this.d.error(`Installation attempt ${attemptNumber} failed:`, errorMessage) | ||
| await this.updateInstallationStatus('failed', attemptNumber, errorMessage) | ||
| this.d.warn(`Installation attempt ${attemptNumber} failed, retrying in 1 second...`, getErrorMessage(error)) | ||
| await deletePendingHelmReleases() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given recent changes about initial install, it seems that this cantons would be called at: https://github.com/linode/apl-core/blob/APL-1150/src/cmd/install.ts#L124
@CasLubbers @merll could you confirm ?
📌 Summary
Fix an issue where installer is restarted and Helm gets stuck in an error.
Error: UPGRADE FAILED: another operation (install/upgrade/rollback) is in progress